Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Quickstart cleanup #394

Merged
merged 2 commits into from
Sep 18, 2024
Merged

docs: Quickstart cleanup #394

merged 2 commits into from
Sep 18, 2024

Conversation

rube-de
Copy link
Contributor

@rube-de rube-de commented Sep 13, 2024

This PR

  • removes truffle
  • makes initial setup clearer
  • changes diff to normal clodeblock with highliting for better copy

our prism dark theme, which is applied on the code-blocks, isn't the best visible. Maybe we could change from dracula to vsDark

@netlify Netlify
Copy link

netlify bot commented Sep 13, 2024 •
edited
Loading

✅ Deploy Preview for oasisprotocol-sapphire-paratime ready!

Name Link
🔨 Latest commit 5ba383a
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-sapphire-paratime/deploys/66e973c8d1ce3c0008f79e35
😎 Deploy Preview https://deploy-preview-394--oasisprotocol-sapphire-paratime.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aefhm aefhm self-requested a review September 15, 2024 14:32
@aefhm aefhm added p:1 Priority: high docs Documentation labels Sep 15, 2024
@aefhm
Copy link
Contributor

aefhm commented Sep 16, 2024

our prism dark theme, which is applied on the code-blocks, isn't the best visible. Maybe we could change from dracula to vsDark

Agree.

aefhm
aefhm approved these changes Sep 16, 2024
View reviewed changes
docs/quickstart.mdx Outdated Show resolved Hide resolved
matevz
matevz approved these changes Sep 16, 2024
View reviewed changes
docs/quickstart.mdx Show resolved Hide resolved
@matevz
Copy link
Member

matevz commented Sep 16, 2024

Don't forget to squash before merging.

Also, please rebase the PR on the latest main branch instead of merging main changes into your PR.

@rube-de
Copy link
Contributor Author

rube-de commented Sep 16, 2024 •
edited
Loading

our prism dark theme, which is applied on the code-blocks, isn't the best visible. Maybe we could change from dracula to vsDark

Agree.

alternative, we could set

[data-theme='dark'] span.token-line.theme-code-block-highlighted-line span.token.comment { 
color: /*somthing better visible like greenish*/
}

to change the color of the highlighted comment

@rube-de rube-de force-pushed the main branch 2 times, most recently from b3f16a7 to fad7fdc Compare September 16, 2024 10:46
@rube-de
docs: Quickstart cleanup
5bb1774 
- removed truffle
- make initial setup clearer
- change diff to normal clodeblock with highliting for better copy

docs: restore some change

docs: update hardhat to 2.19.4

docs: error in merge
@aefhm
Copy link
Contributor

aefhm commented Sep 17, 2024

alternative, we could set
[data-theme='dark'] span.token-line.theme-code-block-highlighted-line span.token.comment {
color: /somthing better visible like greenish/
}
to change the color of the highlighted comment

I'm open to any of these. I think the highlighting you introduced already is a lot better.

@rube-de rube-de merged commit d430814 into oasisprotocol:main Sep 18, 2024
10 checks passed
@rube-de rube-de linked an issue Sep 23, 2024 that may be closed by this pull request
docs: Remove Truffle support #374
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aefhm aefhm aefhm approved these changes

@matevz matevz matevz approved these changes

@CedarMist CedarMist Awaiting requested review from CedarMist

Assignees

@rube-de rube-de

Labels
docs Documentation p:1 Priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: Remove Truffle support
3 participants
@rube-de @aefhm @matevz